Fix TypeError in MiddleWordEm extra when options was None (#627) #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #627, where if the extra options for
middle-word-emwas set toNoneit would raise a TypeError.For extras, it's possible to initialise them without any options like so:
extras={'abc': None}. This is usually handled inExtra.__init__and converted to an empty dictionary, so that the extras don't have to worry about a bunch of runtime type checks:python-markdown2/lib/markdown2.py
Line 2382 in c91007d
However, middle-word-em would try to set some default options before calling
super().__init__, and didn't have sufficient checks for if the value is None. This PR adds a check and converts it to a dict if so